-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to a new S3 bucket #1089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since: * We want the S3 bucket to be owned by a different AWS account and it's not possible to transfer ownership of an existing bucket. * In the future we want to rebuild some of the Python runtime archives (for example to improve the sqlite3 handling, or to tweak the compile flags used), and it will be easier to reason about the change if we can guarantee only recent buildpack versions are using the assets rather than several year old unmaintained forks. The assets were synced from the old bucket using (minus the `--dryrun`): ``` aws s3 sync s3://lang-python s3://heroku-buildpack-python \ --dryrun \ --metadata-directive REPLACE \ --exclude "*" \ --include 'common/*' \ --include 'heroku-*/runtimes/*' \ --include 'heroku-*/libraries/vendor/gdal.tar.gz' \ --include 'heroku-*/libraries/vendor/geos.tar.gz' \ --include 'heroku-*/libraries/vendor/proj.tar.gz' \ --exclude 'common/pip-20.0.2-py2.py3-none-any.whl' \ --exclude '*/runtimes/*-opt.tar.gz' \ --exclude '*/runtimes/sqlite-free/*' ``` The files that were `--exclude`d are those that are no longer used, or test assets that were not officially released. The Cedar-14 assets were not migrated since it's EOL next month. The old S3 bucket will be left untouched for the foreseeable future (ie: we won't be deleting it), since builds using older versions of this buildpack (either due to pinning to a tag or via a fork) will still be using assets from it. Closes W-8060097.
f055ddd
to
496c1b0
Compare
dmathieu
approved these changes
Oct 6, 2020
scorphus
added a commit
to scorphus/platforms
that referenced
this pull request
Oct 15, 2020
heroku-buildpack-python migrated to a new S3 bucket 9 days ago. Here are the details: heroku/heroku-buildpack-python#1089
scorphus
added a commit
to scorphus/platforms
that referenced
this pull request
Oct 15, 2020
heroku-buildpack-python migrated to a new S3 bucket 9 days ago. Here are the details: heroku/heroku-buildpack-python#1089
cezarsa
pushed a commit
to tsuru/platforms
that referenced
this pull request
Oct 15, 2020
heroku-buildpack-python migrated to a new S3 bucket 9 days ago. Here are the details: heroku/heroku-buildpack-python#1089
dryan
pushed a commit
to dryan/heroku-buildpack-python
that referenced
this pull request
Nov 19, 2020
Since: * We want the S3 bucket to be owned by a different AWS account and it's not possible to transfer ownership of an existing bucket. * In the future we want to rebuild some of the Python runtime archives (for example to improve the sqlite3 handling, or to tweak the compile flags used), and it will be easier to reason about the change if we can guarantee only recent buildpack versions are using the assets rather than several year old unmaintained forks. The assets were synced from the old bucket using (minus the `--dryrun`): ``` aws s3 sync s3://lang-python s3://heroku-buildpack-python \ --dryrun \ --metadata-directive REPLACE \ --exclude "*" \ --include 'common/*' \ --include 'heroku-*/runtimes/*' \ --include 'heroku-*/libraries/vendor/gdal.tar.gz' \ --include 'heroku-*/libraries/vendor/geos.tar.gz' \ --include 'heroku-*/libraries/vendor/proj.tar.gz' \ --exclude 'common/pip-20.0.2-py2.py3-none-any.whl' \ --exclude '*/runtimes/*-opt.tar.gz' \ --exclude '*/runtimes/sqlite-free/*' ``` The files that were `--exclude`d are those that are no longer used, or test assets that were not officially released. The Cedar-14 assets were not migrated since it's EOL next month. The old S3 bucket will be left untouched for the foreseeable future (ie: we won't be deleting it), since builds using older versions of this buildpack (either due to pinning to a tag or via a fork) will still be using assets from it. Closes @W-8060097@.
joaodaher
pushed a commit
to edukorg/tsuru-platforms
that referenced
this pull request
Mar 1, 2021
heroku-buildpack-python migrated to a new S3 bucket 9 days ago. Here are the details: heroku/heroku-buildpack-python#1089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
The assets were synced from the old bucket using (minus the
--dryrun
):The files that were
--exclude
d are those that are no longer used, or test assets that were not officially released.The Cedar-14 assets were not migrated since it's EOL next month.
The old S3 bucket will be left untouched for the foreseeable future (ie: we won't be deleting it), since builds using older versions of this buildpack (either due to pinning to a tag or via a fork) will still be using assets from it.
Closes W-8060097.