Add support for the Heroku-22 stack #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
heroku-22-support
branch
2 times, most recently
from
1c5a75b to
08e9285
Compare
This was referenced Apr 12, 2022
edmorley
force-pushed
the
heroku-22-support
branch
from
08e9285 to
28fc1a0
Compare
edmorley
force-pushed
the
heroku-22-support
branch
3 times, most recently
from
7ebe9d2 to
d53ca7a
Compare
edmorley
force-pushed
the
heroku-22-support
branch
2 times, most recently
from
c07f573 to
6d0a2e9
Compare
Adds binary generation and testing support for Heroku-22.
Runtime version support for Heroku-22 is as follows:
* Python 3.6 and older: Not supported since EOL.
* Python 3.7/3.8: Not supported since:
- they are in the security-fix-only phase of their lifecycle
- they reach EOL in 2023-06 and 2024-10 respectively, which is well
before the EOL date of Heroku-22
- upgrading from 3.7/3.9 to 3.9 is in most cases trivial, and
so we should be encouraging users to upgrade.
* Python 3.9: Only 3.9.12+ is supported.
* Python 3.10: Only 3.10.4+ is supported.
* PyPy: Not supported, since is deprecated, was only ever a beta
feature, the PyPy versions available for Heroku-18/20 are
significantly out of date, and usage is virtually non-existent.
The `force_absolute_paths_buildpack` usage in tests has been removed
since:
* Heroku-22 no longer includes Ruby in the stack image, and that
buildpack was implemented in Ruby rather than bash.
* That buildpack doesn't really add any value over just checking that
things we put on the `PATH` (such as Python) can actually be used,
which the existing tests already do.
GUS-W-10343718.
edmorley
force-pushed
the
heroku-22-support
branch
from
6d0a2e9 to
785f288
Compare
joshwlewis
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds binary generation and testing support for Heroku-22.
Runtime version support for Heroku-22 is as follows:
The
force_absolute_paths_buildpackusage in tests has been removed since:PATH(such as Python) can actually be used, which the existing tests already do.GUS-W-10343718.