Skip check for requirement.txt changes when using Pipenv #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Pipenv builds would include a stray error message in the log output, that didn't affect the result of the build, but added noise to the logs and gave the false impression the build was broken in some way: ``` cp: cannot stat '/tmp/build_a123c0456/requirements.txt': No such file or directory ``` This originated from the check of `requirements.txt` changes compared to the copy of the file seen in the last build. This check is only necessary when using Pip (and not Pipenv), so should always have been skipped. Now that the check is fixed, the disabling of bash exit on error mode for part of `bin/steps/python` can more easily be removed, increasing coverage of such issues in the future. Fixes #1270. GUS-W-7924941.
edmorley
force-pushed
the
fix-cp-cannot-stat-warning
branch
from
db79830 to
1e04ed3
Compare
edmorley
commented
Aug 15, 2022
doriskwan
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Pipenv builds would include a stray error message in the log output, that didn't affect the result of the build, but added noise to the logs and gave the false impression the build was broken in some way:
This originated from the check of
requirements.txtchanges compared to the copy of the file seen in the last build. This check is only necessary when using Pip (and not Pipenv), so should always have been skipped.Now that the check is fixed, the disabling of bash exit on error mode for part of
bin/steps/pythoncan more easily be removed, increasing coverage of such issues in the future.Fixes #1270.
GUS-W-7924941.