-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.7.14, 3.8.14 and 3.9.14 #1362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
379f629
to
52567f7
Compare
Since: - The test is currently failing due to https://www.mercurial-scm.org being down, and there aren't many/any other decent testcase alternatives, since so few projects use Mercurial these days (and we also need a testcase that's quick to install and doesn't need additional system libs). - All the test is really testing is that (a) the Mercurial binary is installed in the stack image, (b) that we haven't messed up the `PATH` passed to pip, (c) that Pip doesn't have a regression with Mercurial VCS support. However (a) isn't really a concern of this buildpack, (b) is still tested via the Git testcase, and (c) is unlikely/really an upstream concern (it's not viable/a good use of our time to try and replicate pip's test suite ourselves). GUS-W-11716181.
52567f7
to
b12a758
Compare
Malax
approved these changes
Sep 7, 2022
edmorley
added a commit
that referenced
this pull request
Sep 7, 2022
edmorley
added a commit
that referenced
this pull request
Sep 7, 2022
Since: - The test is currently failing due to https://www.mercurial-scm.org being down, and there aren't many/any other decent testcase alternatives, since so few projects use Mercurial these days (and we also need a testcase that's quick to install and doesn't need additional system libs). - All the test is really testing is that (a) the Mercurial binary is installed in the stack image, (b) that we haven't messed up the `PATH` passed to pip, (c) that Pip doesn't have a regression with Mercurial VCS support. However (a) isn't really a concern of this buildpack, (b) is still tested via the Git testcase, and (c) is unlikely/really an upstream concern (it's not viable/a good use of our time to try and replicate pip's test suite ourselves). GUS-W-11716181.
https://devcenter.heroku.com/articles/python-support#specifying-a-python-version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.python.org/downloads/release/python-3714/
https://www.python.org/downloads/release/python-3814/
https://www.python.org/downloads/release/python-3914/
GUS-W-11716181.