Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7.14, 3.8.14 and 3.9.14 #1362

Merged
merged 3 commits into from
Sep 7, 2022
Merged

Conversation

@edmorley edmorley self-assigned this Sep 7, 2022
Since:
- The test is currently failing due to https://www.mercurial-scm.org being
  down, and there aren't many/any other decent testcase alternatives,
  since so few projects use Mercurial these days (and we also need a
  testcase that's quick to install and doesn't need additional system libs).
- All the test is really testing is that (a) the Mercurial binary is installed in
  the stack image, (b) that we haven't messed up the `PATH` passed to
  pip, (c) that Pip doesn't have a regression with Mercurial VCS support.
  However (a) isn't really a concern of this buildpack, (b) is still tested via
  the Git testcase, and (c) is unlikely/really an upstream concern (it's not
  viable/a good use of our time to try and replicate pip's test suite
  ourselves).

GUS-W-11716181.
@edmorley edmorley marked this pull request as ready for review September 7, 2022 09:24
@edmorley edmorley requested a review from a team as a code owner September 7, 2022 09:24
@edmorley edmorley merged commit 56c596f into main Sep 7, 2022
@edmorley edmorley deleted the python-releases branch September 7, 2022 10:02
edmorley added a commit that referenced this pull request Sep 7, 2022
Since:
- The test is currently failing due to https://www.mercurial-scm.org being
  down, and there aren't many/any other decent testcase alternatives,
  since so few projects use Mercurial these days (and we also need a
  testcase that's quick to install and doesn't need additional system libs).
- All the test is really testing is that (a) the Mercurial binary is installed in
  the stack image, (b) that we haven't messed up the `PATH` passed to
  pip, (c) that Pip doesn't have a regression with Mercurial VCS support.
  However (a) isn't really a concern of this buildpack, (b) is still tested via
  the Git testcase, and (c) is unlikely/really an upstream concern (it's not
  viable/a good use of our time to try and replicate pip's test suite
  ourselves).

GUS-W-11716181.
@edmorley
Copy link
Member Author

edmorley commented Sep 7, 2022

$ make publish
Deploy as version: v218 [y/n]? y

Tagging commit 56c596f662af1f1f59ec33013d3da18b3fa9ea52 with v218... 
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/heroku/heroku-buildpack-python
 * [new tag]         v218 -> v218

Publishing to the buildpack registry...
Two-factor code: ********************************************
Publishing buildpack heroku/python... done
Publishing buildpack was successful

Version  Released At               Status
───────  ────────────────────────  ─────────
218      2022-09-07T10:04:47.518Z  published

https://devcenter.heroku.com/articles/python-support#specifying-a-python-version
https://devcenter.heroku.com/changelog-items/2466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants