Downgrade pipenv from 2023.2.18 to 2023.2.4 #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipenv 2023.2.18 raised its minimum setuptools version to 67.x, which is newer than the setuptools version the buildpack pins to. This succeeds on the first build, however, for cached rebuilds then fails due to pip's version resolver not allowing overriding already-installed dependency versions when resolving version conflicts. A new testcase has been added for pipenv caching (caching was already extensively tested when using pip, just not when using pipenv). Resolves: ``` remote: -----> Installing pip 23.0.1, setuptools 63.4.3 and wheel 0.38.4 remote: ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. remote: pipenv 2023.2.18 requires setuptools>=67.0.0, but you have setuptools 63.4.3 which is incompatible. ``` Longer term we will update to newer setuptools ourselves (once the dust settles on the many breaking changes introduced in newer setuptools versions), and hopefully newer pipenv will also relax its minimum setuptools version slightly. GUS-W-12670935.
edmorley
force-pushed
the
downgrade-pipenv
branch
from
aeba1e6 to
cb87f84
Compare
Malax
approved these changes
Mar 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv 2023.2.18 raised its minimum setuptools version to 67.x, which is newer than the setuptools version the buildpack pins to. This succeeds on the first build, however, for cached rebuilds then fails due to pip's version resolver not allowing overriding already-installed dependency versions when resolving version conflicts.
A new testcase has been added for pipenv caching (caching was already extensively tested when using pip, just not when using pipenv).
Resolves:
Longer term we will update to newer setuptools ourselves (once the dust settles on the many breaking changes introduced in newer setuptools versions), and hopefully newer pipenv will also relax its minimum setuptools version slightly.
Partially reverts #1412.
GUS-W-12670935.