Use the bundled pip wheel to perform pip bootstrap #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the buildpack downloaded a pip wheel from S3 in order to bootstrap the pip/setuptools/wheel installation. Newer Python versions (Python 3.4+) bundle a pip wheel as part of the `ensurepip` module, which we can use instead of having to perform this download now that we've dropped support for Python 2. This approach: - improves performance/reliability of repeat builds, since it saves having to download the pip wheel each time - reduces the toil of performing pip updates, since we no longer need to upload new pip versions to the S3 bucket each time - matches the approach already used in the new Python CNB. GUS-W-13111316.
edmorley
force-pushed
the
use-bundled-pip
branch
from
64ecbd3
to
f49089c
Compare
Malax
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
Merged
edmorley
added a commit
that referenced
this pull request
Apr 27, 2023
In some older versions of Python multiple pip wheels have been accidentally bundled with the Python stdlib upstream. For example in Python 3.9.0 (which has been superseded by newer patch versions of Python 3.9.x): https://github.com/python/cpython/tree/v3.9.0/Lib/ensurepip/_bundled After #1442, this results in eg: ``` -----> Installing pip 23.1.2, setuptools 67.7.2 and wheel 0.40.0 /app/.heroku/python/bin/python: can't open file '/build/.heroku/python/lib/python3.9/ensurepip/_bundled/pip-20.2.1-py2.py3-none-any.whl .heroku/python/lib/python3.9/ensurepip/_bundled/pip-20.2.3-py2.py3-none-any.whl/pip': [Errno 2] No such file or directory ``` Whilst these affected Python versions are old/insecure and not available on newer stacks, we should still make sure they work as expected. As such, the lookup of the bundled pip wheel needs to handle this case, which it now does by just picking the first found pip wheel. This was spotted via https://heroku.support/1245122, which was from an app using the `main` branch of this buildpack (since #1442 hasn't yet been released to the buildpack registry). GUS-W-13111316.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the buildpack downloaded a pip wheel from S3 in order to bootstrap the pip/setuptools/wheel installation.
Newer Python versions (Python 3.4+) bundle a pip wheel as part of the
ensurepipmodule, which we can use instead of having to perform this download now that we've dropped support for Python 2.This approach:
GUS-W-13111316.