Replace the runtime-fixer Python script with Bash
#1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy `runtime-fixer` script uses Python which is problematic since the script has to run prior to the buildpack actually installing Python. As such: - For clean installs of new apps (where there is no cached Python install), the script ends up relying upon system Python. - For cached builds, the script ends up using the Python install restored from the cache. If an app has changed stack, this means a Python install intended for one Ubuntu version ends up being used on another during the next build. In the case of stack downgrades this results in a glibc warning (it's only a warning rather than an error, since the script is allowed to fail, because of this bug). There was unfortunately no explanation given as to why Python was chosen when the `runtime-fixer` script was first added: df52fd4 (It probably didn't help that there were no stack change tests back then.) Regardless, the only purpose of this script is to trim whitespace from the contents of `runtime.txt`, which we can easily do using Bash built-ins instead to avoid this issue. The whitespace stripping already has a test, which still passes: https://github.com/heroku/heroku-buildpack-python/blob/84684a01dc5b2ec73e6debf3cfeda008f15db1a4/spec/hatchet/python_version_spec.rb#L236-L240 As an added bonus, removing the `runtime-fixer` script means we won't have to make it compatible with the `python` -> `python3` switch for Heroku-24. GUS-W-8059923.
edmorley
force-pushed
the
rm-runtime-fixer
branch
from
41b1abe
to
20edd4c
Compare
runesoerensen
approved these changes
Apr 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy
runtime-fixerscript uses Python which is problematic since the script has to run prior to the buildpack actually installing Python.As such:
There was unfortunately no explanation given as to why Python was chosen when the
runtime-fixerscript was first added:df52fd4
(It probably didn't help that there were no stack change tests back then.)
Regardless, the only purpose of this script is to trim whitespace from the contents of
runtime.txt, which we can easily do using Bash built-ins instead to avoid this issue.The whitespace stripping already has a test, which still passes.
As an added bonus, removing the
runtime-fixerscript means we won't have to make it compatible with thepython->python3switch for Heroku-24.GUS-W-8059923.