Merge pull request #958 from heroku/schneems/fix-logic-inversion

Fix version download warning logic

CHANGELOG.md

@@ -1,5 +1,10 @@
 ## Master (unreleased)
 
+
+## v210 (3/6/2020)
+
+* Fix version download error warning inversion logic (https://github.com/heroku/heroku-buildpack-ruby/pull/958)
+
 ## v209 (3/5/2020)
 
 * Fix bug in version download error message logic (https://github.com/heroku/heroku-buildpack-ruby/pull/957)

lib/language_pack/ruby.rb

@@ -450,7 +450,7 @@ def warn_outdated_ruby
   def warn_stack_upgrade
     return unless defined?(@ruby_download_check)
     return unless @ruby_download_check.next_stack(current_stack: stack)
-    return unless @ruby_download_check.exists_on_next_stack?(current_stack: stack)
+    return if @ruby_download_check.exists_on_next_stack?(current_stack: stack)
 
     warn(<<~WARNING)
       Your Ruby version is not present on the next stack

lib/language_pack/version.rb

@@ -2,6 +2,6 @@
 
 module LanguagePack
   class LanguagePack::Base
-    BUILDPACK_VERSION = "v209"
+    BUILDPACK_VERSION = "v210"
   end
 end

spec/hatchet/ruby_spec.rb

@@ -100,6 +100,7 @@
         Hatchet::Runner.new("default_ruby").deploy do |app, heroku|
           expect(app.output).to     include("Writing config/database.yml to read from DATABASE_URL")
           expect(app.output).not_to include("Your app was upgraded to bundler")
+          expect(app.output).not_to include("Your Ruby version is not present on the next stack")
         end
       end
     end