Allow support for BUNDLE_WITHOUT with spaces #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/bundled_with-with-spaces
branch
from
968841a to
17e646e
Compare
danielleadams
approved these changes
Oct 7, 2020
edmorley
reviewed
Oct 7, 2020
There was a problem hiding this comment.
Hi! Would it be worth also wrapping all of the env vars in quotes, to avoid malformed vars breaking the bash command, here?
#1052 (comment)
schneems
force-pushed
the
schneems/bundled_with-with-spaces
branch
2 times, most recently
from
9b099f3 to
1e2441f
Compare
In v218 we switched from configuring bundler via flags to env vars. It turns out that bundler supports defining an `--without` value with a space in it, but it does not support BUNDLE_WITHOUT with a space in it: ``` $ bundle install --without foo bar $ bundle config | grep without -a1 without Set for your local app (/private/tmp/40a4b42d7e884ebf62a1f85a3c5abd38/.bundle/config): [:foo, :bar] ``` But: ``` $ BUNDLE_WITHOUT="foo bar" bundle config | grep without -a1 without Set via BUNDLE_WITHOUT: [:"foo bar"] ``` > Note in this example it is showing `:"foo bar"` as one group instead of two values. To fix this, we can reproduce the bundler logic of replacing a space with a colon https://github.com/rubygems/rubygems/blob/ce27b98272d5c37ebf45b2b1b66894699ae47d58/bundler/lib/bundler/cli/install.rb#L151. Related ticket: https://heroku.support/924687
schneems
force-pushed
the
schneems/bundled_with-with-spaces
branch
from
1e2441f to
0ade9e0
Compare
|
@edmorley seems good. It's this now: |
|
@schneems Yeah I realise the bug is fixed; I mean more that normally when writing a bash script, it's best practice to put all variable usage inside double quotes (eg it's a shellcheck lint error to not do so). Whilst the bash command for the bundle install is an inline concatenation in Ruby, this still seems like something worth doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v218 we switched from configuring bundler via flags to env vars. It turns out that bundler supports defining an
--withoutvalue with a space in it, but it does not support BUNDLE_WITHOUT with a space in it:But:
To fix this, we can reproduce the bundler logic of replacing a space with a colon https://github.com/rubygems/rubygems/blob/ce27b98272d5c37ebf45b2b1b66894699ae47d58/bundler/lib/bundler/cli/install.rb#L151.
Related ticket: https://heroku.support/924687