[close #1069] Remove Active Storage warnings #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/remove-active-storage-warnings
branch
from
e3b1920 to
7b02689
Compare
edmorley
approved these changes
Oct 8, 2020
There are two active storage warnings: - Warn when storage is set to :local - Warn when ffmpeg is not present on the system ## Warn when storage is set to :local The goal here was to prevent people from accidentally uploading assets only to find out that they disappear every 24 hours after the dyno resets. While that's still a problem now, the default value is `:local` when you generate a new project. That means just because someone has this set to be local does not mean they're using active storage. That also means that this generates a useless warning message and clutters their deploy. This PR removes that warning ## Warn when ffmpeg is not present on the system If popper and ffmpeg are not on the system then Rails cannot generate previews for PDFs and videos which is a feature of active storage. To help, we added a warning if you're using active storage but don't have these dependencies. Unfortunately, we can't tell if you're actually using these features or not, so there's no easy way to disable this warning if they are not needed. In general these warnings cause a lot of clutter and confusion.
schneems
force-pushed
the
schneems/remove-active-storage-warnings
branch
from
7b02689 to
4cd3a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two active storage warnings:
Warn when storage is set to :local
The goal here was to prevent people from accidentally uploading assets only to find out that they disappear every 24 hours after the dyno resets.
While that's still a problem now, the default value is
:localwhen you generate a new project. That means just because someone has this set to be local does not mean they're using active storage. That also means that this generates a useless warning message and clutters their deploy.This PR removes that warning
Warn when ffmpeg is not present on the system
If popper and ffmpeg are not on the system then Rails cannot generate previews for PDFs and videos which is a feature of active storage. To help, we added a warning if you're using active storage but don't have these dependencies.
Unfortunately, we can't tell if you're actually using these features or not, so there's no easy way to disable this warning if they are not needed.
In general these warnings cause a lot of clutter and confusion.