Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v224 #1128

Merged
merged 1 commit into from
Feb 24, 2021
Merged

v224 #1128

merged 1 commit into from
Feb 24, 2021

Conversation

schneems
Copy link
Contributor

No description provided.

@schneems schneems requested a review from a team as a code owner February 24, 2021 20:21
edmorley
edmorley approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should changelogs/v224/.gitkeep be deleted?
(The directory is no longer empty, so doesn't need a .gitkeep)

@schneems
Copy link
Contributor Author

It's not hurting anything where it is. It's an artifact of me doing this:

  467  mv changelogs/unreleased/ changelogs/v224
  468  mkdir changelogs/unreleased
  469  touch changelogs/unreleased/.gitkeep

It's the copied over .gitkeep from the prior unreleased folder. I guess I could copy over *.md files maybe...It's all manual for now.

@schneems schneems merged commit 3dab1a3 into main Feb 24, 2021
@schneems schneems deleted the v224 branch February 24, 2021 20:27
krisrang added a commit to skyltmax/heroku-buildpack-ruby that referenced this pull request May 13, 2021
@krisrang
Merge remote-tracking branch 'upstream/main'
c5894e2 
* upstream/main: (52 commits)
  Fix date (heroku#1152)
  Bundler 2.2.16 (heroku#1150)
  v226 (heroku#1149)
  [changelog skip] Remove Heroku-16 from tests: (heroku#1146)
  [close 1135] Update bundler 2.x to 2.2.15 (heroku#1144)
  [changelog skip] Clean up mime magic in repos (heroku#1145)
  Clean up CNB release process (heroku#1139)
  Use correct method name in script heroku#1129 (heroku#1129)
  Post-release updates: heroku/ruby 0.1.0 (heroku#1138)
  Add package.toml (heroku#1137)
  Add CNB release scripts (heroku#1136)
  Release v225 (heroku#1133)
  [close heroku#1126] Update bundler to 2.2.11 (heroku#1132)
  Update buildpack tests (heroku#1131)
  v224 (heroku#1128)
  Use jvm buildpack to install JRuby dependencies (heroku#1119)
  Fix YAML formatting (heroku#1116)
  Rails 2, 3, and 4 LTS tests (heroku#1115)
  v223 (heroku#1114)
  Fail detection with a CNB-friendly exit code (heroku#1112)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneems @edmorley