Remove Ruby dependency on bin/release #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/bash-release
branch
from
0e4908b to
ef19f03
Compare
On heroku-22 there is no longer a system Ruby so we cannot depend on it. We can either bootstrap as we do in `bin/compile` or use bash. Considering this logic is trivial to represent in bash that's what we will do.
schneems
force-pushed
the
schneems/bash-release
branch
from
ef19f03 to
30a663f
Compare
joshwlewis
approved these changes
Jun 6, 2022
|
Verifying this does work manually: |
edmorley
added a commit
that referenced
this pull request
Jun 7, 2022
Whilst the `tmp/heroku-buildpack-release-step.yml` file is always written by the buildpack during `bin/compile`, some apps use third-party slug cleaner buildpacks to remove this and other files, during their later `bin/compile` steps. This restores the `bin/release` behaviour prior to #1308, whereby the file being missing (at the time of the release step) is not treated as an error. This unblocks us adjusting the build system to make non-zero `bin/release` exit codes fatal, since otherwise too many existing apps would start failing. Longer term if the Ruby buildpack wanted to ensure slug cleaner buildpacks did not accidentally break the features supported by `bin/release`, the release output file could be renamed from `tmp/heroku-buildpack-release-step.yml` to something else (so it evades cleanup), then for bonus points, `bin/release` would clean that file up itself, so that it didn't end up in the slug. However such a change would be need to be rolled out carefully, in case people were depending on the presence of `tmp/heroku-buildpack-release-step.yml`, so is out of scope for this PR. GUS-W-10343881.
schneems
pushed a commit
that referenced
this pull request
Jun 7, 2022
Whilst the `tmp/heroku-buildpack-release-step.yml` file is always written by the buildpack during `bin/compile`, some apps use third-party slug cleaner buildpacks to remove this and other files, during their later `bin/compile` steps. This restores the `bin/release` behaviour prior to #1308, whereby the file being missing (at the time of the release step) is not treated as an error. This unblocks us adjusting the build system to make non-zero `bin/release` exit codes fatal, since otherwise too many existing apps would start failing. Longer term if the Ruby buildpack wanted to ensure slug cleaner buildpacks did not accidentally break the features supported by `bin/release`, the release output file could be renamed from `tmp/heroku-buildpack-release-step.yml` to something else (so it evades cleanup), then for bonus points, `bin/release` would clean that file up itself, so that it didn't end up in the slug. However such a change would be need to be rolled out carefully, in case people were depending on the presence of `tmp/heroku-buildpack-release-step.yml`, so is out of scope for this PR. GUS-W-10343881.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On heroku-22 there is no longer a system Ruby so we cannot depend on it. We can either bootstrap as we do in
bin/compileor use bash. Considering this logic is trivial to represent in bash that's what we will do.GUS-W-10343881.