Bump default Node.js and Yarn versions #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
colincasey
approved these changes
Nov 29, 2022
|
Suggest that you update the Heroku developer documentation to reflect this change: https://devcenter.heroku.com/articles/ruby-support#installed-binaries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1331, the Node.js version change to 18.x is likely to cause issues for folks running on
heroku-18(as mentioned in #1331 (review)). This is an alternative update, which should bring both the defaultyarnandnodeinstallations to the most recent patch without negatively impacting users onheroku-18. Node.js 16 is a maintenance LTS, so should be fine to use for a bit longer. Longer term, we may want to conditionally select Node.js 18 for folks onheroku-20+.