Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using default node or yarn versions #1401

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Warn when using default node or yarn versions #1401

merged 2 commits into from
Nov 8, 2023

Commits on Nov 8, 2023

  1. Warn when using default node or yarn versions 

    Many developers don't realize they're using a default version. When it changes, like https://devcenter.heroku.com/changelog-items/2710, they're surprised to find that even a correctly committed `package.json` with a node engine declaration does not install the version they're expecting. This is because the Ruby build pack does not duplicate the Node build pack's version detection logic. 

The Ruby build pack installs a version of node for historical reasons. It pre-dates multi-build packs from when applications simply needed **a** version of node for execjs to function along with the Rails asset pipeline (sprockets). As the ecosystem has matured, our recommendations also change. We recommend not relying on this default behavior.

It's worth noting that the CNB behavior (not yet available on Heroku) defers installing node to the nodes-engine build pack which is the ideal behavior so that there are not two independent paths for node support.
    Richard Schneeman committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    012876f View commit details
    Browse the repository at this point in the history

  2. Add changelog notes

    Richard Schneeman committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f441211 View commit details
    Browse the repository at this point in the history