Fix tests after bundler change - Stacked 1/3 #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ruby buildpack uses the Ruby buildpack on CI. When the bundler versions changed in 56ff138 it also changed the behavior of these tests (which use the local bundler version). That means that after the buildpack was deployed, it retroactively meant that tests on main were failing. The issue with these tests is that they're using a feature of bundler that's been removed, specifically this change https://devcenter.heroku.com/changelog-items/2809. In these tests the Ruby version is specified in the Gemfile but not the Gemfile.lock: - Gemfile https://github.com/sharpstone/mri_193/blob/master/Gemfile - Gemfile.lock https://github.com/sharpstone/mri_193/blob/master/Gemfile.lock With the newer version of bundler, these tests now fail. To fix this tests will need to be updated or removed (based on their current relevance).
schneems
commented
Apr 15, 2024
schneems
commented
Apr 15, 2024
schneems
commented
Apr 15, 2024
schneems
commented
Apr 15, 2024
schneems
changed the title
joshwlewis
approved these changes
Apr 15, 2024
|
It was merged in with #1440 which was also approved. I clicked the "enable auto merge" but didn't see that my own comments were considered blocking so it wasn't merged in. That PR had the exact same commits anyway, so it's the exact same code. Leaving a note as to why I'm closing this after approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby buildpack uses the Ruby buildpack on CI. When the bundler versions changed in 56ff138 it also changed the behavior of these tests (which use the local bundler version). That means that after the buildpack was deployed, it retroactively meant that tests on main were failing.
The issue with these tests is that they're using a feature of bundler that's been removed, specifically this change https://devcenter.heroku.com/changelog-items/2809. In these tests the Ruby version is specified in the Gemfile but not the Gemfile.lock:
With the newer version of bundler, these tests now fail. To fix this tests will need to be updated or removed (based on their current relevance).