Better failure message for CI apps using default stack #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/heroku-18-bandaid
branch
from
1424c69 to
bf8ca3c
Compare
jmorrell
approved these changes
Sep 13, 2018
schneems
force-pushed
the
schneems/heroku-18-bandaid
branch
from
bf8ca3c to
a358bfa
Compare
schneems
force-pushed
the
schneems/heroku-18-bandaid
branch
from
a358bfa to
32ac3ae
Compare
This test was added to ensure that we didn't accidentally write-over a user's environment variables when we first introduced "user env compile" as a default. It's no longer needed and Rails 4.0 apps cannot install with Ruby 2.4 or 2.5 and that is the only currently available rubies on Heroku 18.
tt
reviewed
Sep 14, 2018
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ## Master | |||
|
|
|||
| ## v192 (9/14/2018) | |||
|
|
|||
| * Add error messages when using unsupported Ruby versions on the Heroku 18 stack (https://github.com/heroku/heroku-buildpack-ruby/pull/809) | |||
lib/language_pack/ruby.rb
Outdated
| message = <<ERROR | ||
| An error occurred while installing #{ruby_version.version_for_download} | ||
|
|
||
| This version of Ruby is not available on Heroku 18. The minimum supported version |
lib/language_pack/ruby.rb
Outdated
| An error occurred while installing #{ruby_version.version_for_download} | ||
|
|
||
| This version of Ruby is not available on Heroku 18. The minimum supported version | ||
| of Ruby on the Heroku 18 stack can found at: |
lib/language_pack/ruby.rb
Outdated
|
|
||
| ci_message = <<ERROR | ||
|
|
||
| If you did not intend to build your app for CI on the Heroku 18 stack |
| mcount "fail.bad_version_fetch.heroku-18.ci" | ||
| message << ci_message | ||
| else | ||
| mcount "fail.bad_version_fetch.heroku-18" |
There was a problem hiding this comment.
Maybe instead of this add a generic mcount "fail.bad_version_fetch.#{stack}.#{ruby_version.version_for_download}" after this block. That will give us data for future stacks without having to go back and change this.
There was a problem hiding this comment.
The way we're measuring failures doesn't like reporting the same failure twice under the same key i.e. fail. Otherwise you can end up with failure rates that are higher than 100% we're doing that for version numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.