-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support io.buildpacks.stacks.bionic stack #945
Conversation
This is needed because docker when running CNB does not set a $PORT by default locally.
[This RFC](buildpacks/rfcs#40) is working its way through and it seems useful to be able to use Heroku buildpacks on `cloudfoundry/cnb:bionic`. This also aligns with how riff is compatible with [multiple stacks](https://github.com/projectriff/node-function-buildpack/blob/master/buildpack.toml#L22).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to test a base bionic stack, to see what mixins we need to use.
@hone I built a couple images for you.
I tried to see what packages are missing but I was getting obscure errors.
Besides playing whack-a-mole, I'm not sure what the best option would be for figuring out what a buildpack like this needs to operate package wise... |
3410e40
to
07b7818
Compare
a5feb38
to
45003b9
Compare
Is this still needed after #888 was merged? |
I think you safely can close and re-do this when it comes back up as a priority. |
This RFC is working its way through and it seems useful to be able to use Heroku buildpacks on
cloudfoundry/cnb:bionic
. This also aligns with how riff is compatible with multiple stacks.