Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support io.buildpacks.stacks.bionic stack #945

Closed
wants to merge 12 commits into from
Closed

Conversation

jabrown85
Copy link

This RFC is working its way through and it seems useful to be able to use Heroku buildpacks on cloudfoundry/cnb:bionic. This also aligns with how riff is compatible with multiple stacks.

Copy link
Member

@hone hone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to test a base bionic stack, to see what mixins we need to use.

@jabrown85
Copy link
Author

@hone I built a couple images for you.

build-image = "heroku/heroku-private:cnb-bionic-build"
run-image = "heroku/heroku-private:cnb-bionic-run"

I tried to see what packages are missing but I was getting obscure errors.

» cat builder-bionic.toml 
[stack]
id = "io.buildpacks.stacks.bionic"
build-image = "heroku/heroku-private:cnb-bionic-build"
run-image = "heroku/heroku-private:cnb-bionic-run"

[lifecycle]
version = "0.5.0"

[[buildpacks]]
  id = "heroku/ruby"
  # TODO: release with https://github.com/heroku/heroku-buildpack-ruby/pull/945
  uri = "buildpacks/heroku-ruby-test"
  #uri = "https://github.com/heroku/heroku-buildpack-ruby/releases/download/cnb-alpha/ruby-buildpack-vCNB-alpha.tgz"

[[order]]
  [[order.group]]
    id = "heroku/ruby"
    version = "0.0.1"
$ pack create-builder bionic-services --builder-config builder-bionic.toml --no-pull
$ docker run -v ~/dev/ruby-getting-started:/workspace -it -u 0 bionic-services bash
root@15fba3c219f3: apt-get update && apt-get upgrade -y && apt-get install -y --no-install-recommends curl && apt-get install -y --no-install-recommends ca-certificates
root@15fba3c219f3:/layers# /cnb/lifecycle/detector
heroku/ruby 0.0.1
root@15fba3c219f3:/layers# /cnb/lifecycle/builder
  Failed to download a Ruby executable for bootstrapping!

  This is most likely a temporary internal error. If the problem
  persists, make sure that you are not running a custom or forked
  version of the Heroku Ruby buildpack which may need updating.
/cnb/buildpacks/heroku_ruby/0.0.1/bin/build: line 17: /tmp/tmp.RngcFgXVfQ/bin/ruby: No such file or directory
ERROR: failed to build: exit status 127
root@15fba3c219f3:/layers#

Besides playing whack-a-mole, I'm not sure what the best option would be for figuring out what a buildpack like this needs to operate package wise...

@schneems
Copy link
Contributor

Is this still needed after #888 was merged?

@jabrown85
Copy link
Author

I think you safely can close and re-do this when it comes back up as a priority.

@schneems schneems closed this Apr 29, 2020
@edmorley edmorley deleted the support-cnb-bionic branch March 1, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants