This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
CRLF http header injection #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the build is failing due to some Docker-related issues, but these changes look good to me 👍 |
|
@mattreduce yeah, CircleCI operates docker a bit different than locally, so I need to massage it and workaround some issues. I'll get that fixed up before I merge. |
hone
force-pushed
the
crlf_http_header_injection
branch
from
4004147 to
5a510f7
Compare
…r SSL termination
Fixes the following: curl -i http://conway-hi-poc.herokuapp.com/%0d%0aset-cookie:%20test=123; HTTP/1.1 301 Moved Permanently Connection: keep-alive Server: nginx Date: Wed, 06 Jul 2016 23:44:00 GMT Content-Type: text/html Content-Length: 178 Location: https://conway-hi-poc.herokuapp.com/ Set-Cookie: test=123 Via: 1.1 vegur <html> <head><title>301 Moved Permanently</title></head> <body bgcolor="white"> <center><h1>301 Moved Permanently</h1></center> <hr><center>nginx</center> </body> </html>
hone
force-pushed
the
crlf_http_header_injection
branch
from
5a510f7 to
6c113d3
Compare
Circle CI does not allow deletion of containers: Cannot destroy container 6f30ab3de4f445d4fe47059d68d9798d40f5f66b9a1120dcfd130c0cab378cb5: Driver btrfs failed to remove root filesystem 6f30ab3de4f445d4fe47059d68d9798d40f5f66b9a1120dcfd130c0cab378cb5: Failed to destroy btrfs snapshot: operation not permitted
…ner orchestration
hone
force-pushed
the
crlf_http_header_injection
branch
from
d2f575f to
c378c66
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattreduce reported that the static buildpack is vulnerable to CRLF injection when you try to visit it without HTTPS and you've not received the STS header yet (initial redirect to force SSL).
You can see it adds a header to its response that you inject in your own request:
cURL output for a request with header injection:
This patch fixes it as well as add SSL termination to the test infrastructure so we can test against SSL.