Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with other 'ps' commands besides 'ps:exec' #51

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

sbosio
Copy link
Contributor

@sbosio sbosio commented Dec 27, 2024

Description

When changes were introduced on heroku-exec-util to handle Fir apps, the signature for its initFeature function was changed, but only ps:exec command was modified on this project to use the new signature, breaking all other implemented commands: ps:forward, ps:copy and ps:socks that also used that function to initialize the configuration.

Here we fix those issues adding the missing parameter to the function call on all commands except for ps:status that seems to be dead code and should be removed on a follow up PR. We also introduce a change when connecting the local forwarded port to the SOCKSv5 server replacing '127.0.0.1' for 'localhost' as the proxyHost in ps:forward to fix a connection issue when the host uses IPv6 DNS resolution.

Finally, there's an integration test available at /bin/test that was completely broken after Ruby libraries were removed from heroku-22 and newer stacks. Here we provide a fix for that test to allow at least testing on a local development box.

Test

Run yarn test

Issues

Fixes heroku/cli#3153.

SOC2

GUS Work Item (Heroku internal)

@sbosio sbosio requested a review from a team as a code owner December 27, 2024 21:22
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this. And thank you for fixing the tests!

@sbosio sbosio merged commit ed770b4 into main Jan 2, 2025
1 check passed
@sbosio sbosio deleted the sbosio/fix-ps-forward branch January 2, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ps:forward crashes with error "callback is not a function" on CLI version 10.0.0
3 participants