Fixing bug with other 'ps' commands besides 'ps:exec' #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When changes were introduced on
heroku-exec-util
to handle Fir apps, the signature for itsinitFeature
function was changed, but onlyps:exec
command was modified on this project to use the new signature, breaking all other implemented commands:ps:forward
,ps:copy
andps:socks
that also used that function to initialize the configuration.Here we fix those issues adding the missing parameter to the function call on all commands except for
ps:status
that seems to be dead code and should be removed on a follow up PR. We also introduce a change when connecting the local forwarded port to the SOCKSv5 server replacing '127.0.0.1' for 'localhost' as theproxyHost
inps:forward
to fix a connection issue when the host uses IPv6 DNS resolution.Finally, there's an integration test available at
/bin/test
that was completely broken after Ruby libraries were removed fromheroku-22
and newer stacks. Here we provide a fix for that test to allow at least testing on a local development box.Test
Run
yarn test
Issues
Fixes heroku/cli#3153.
SOC2
GUS Work Item (Heroku internal)