Additionally transform hyphens to underscores for trace names

heroku · Nov 30, 2023 · 5b911db · 5b911db
1 parent 4edd307
commit 5b911db
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/libcnb/src/tracing.rs b/libcnb/src/tracing.rs
@@ -31,7 +31,10 @@ pub(crate) struct BuildpackTrace {
 /// Open Telemetry file export. The resulting trace provider and span are
 /// enriched with data from the buildpack and the rust environment.
 pub(crate) fn start_trace(buildpack: &Buildpack, phase_name: &'static str) -> BuildpackTrace {
-    let trace_name = format!("{}-{phase_name}", buildpack.id.replace(['/', '.'], "_"));
+    let trace_name = format!(
+        "{}-{phase_name}",
+        buildpack.id.replace(['/', '.', '-'], "_")
+    );
     let tracing_file_path = Path::new(TELEMETRY_EXPORT_ROOT).join(format!("{trace_name}.jsonl"));
 
     // Ensure tracing file path parent exists by creating it.

diff --git a/test-buildpacks/tracing/tests/integration_test.rs b/test-buildpacks/tracing/tests/integration_test.rs
@@ -26,7 +26,7 @@ fn test_tracing_export_file() {
     TestRunner::default().build(&build_config, |context| {
         // Ensure expected span names for detect and build phases are present
         // in the file export contents.
-        assert_contains!(context.pack_stdout, "libcnb-test-buildpacks_tracing-detect");
-        assert_contains!(context.pack_stdout, "libcnb-test-buildpacks_tracing-build");
+        assert_contains!(context.pack_stdout, "libcnb_test_buildpacks_tracing-detect");
+        assert_contains!(context.pack_stdout, "libcnb_test_buildpacks_tracing-build");
     });
 }