Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target triple to buildpack output path #580

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

Malax
Copy link
Member

@Malax Malax commented Jun 22, 2023

When building a buildpack for multiple target triples, the same output directory is currently used by libcnb-cargo, clobbering earlier builds for other target triples. This PR changes the output directory to include the target triple, just as cargo itself does.

Fixes #579

@Malax Malax force-pushed the malax/add-target-triple-to-bp-target-dir branch 2 times, most recently from 7151a23 to 0769f87 Compare June 22, 2023 09:09
@Malax Malax force-pushed the malax/add-target-triple-to-bp-target-dir branch from 5297a16 to 1025f4d Compare June 22, 2023 09:21
@Malax Malax marked this pull request as ready for review June 22, 2023 09:29
@Malax Malax requested a review from a team as a code owner June 22, 2023 09:29
@Malax Malax merged commit 7f64ab0 into main Jun 28, 2023
@Malax Malax deleted the malax/add-target-triple-to-bp-target-dir branch June 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Arch Directory Structure
3 participants