Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcnb-test: Only expose ports to localhost #610

Merged
merged 1 commit into from
Jul 24, 2023
Merged

libcnb-test: Only expose ports to localhost #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ libcnb package` will refer to the new locations. ([#580](https://github.com/hero
- `libherokubuildpack`: Switch the `flate2` decompression backend from `miniz_oxide` to `zlib`. ([#593](https://github.com/heroku/libcnb.rs/pull/593))
- Bump minimum external dependency versions. ([#587](https://github.com/heroku/libcnb.rs/pull/587))

### Fixed

- `libcnb-test`: `ContainerContext::expose_port` now only exposes the port to localhost. ([#610](https://github.com/heroku/libcnb.rs/pull/610))

## [0.13.0] 2023-06-21

The highlight of this release is the `cargo libcnb package` changes to support compilation of both buildpacks and meta-buildpacks.
Expand Down
8 changes: 4 additions & 4 deletions libcnb-test/src/container_port_mapping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ pub(crate) fn port_mapped_container_config(
(
format!("{port}/tcp"),
Some(vec![PortBinding {
host_ip: None,
host_ip: Some(String::from("127.0.0.1")),
edmorley marked this conversation as resolved.
Show resolved Hide resolved
host_port: None,
}]),
)
Expand Down Expand Up @@ -205,21 +205,21 @@ mod tests {
(
String::from("80/tcp"),
Some(vec![PortBinding {
host_ip: None,
host_ip: Some(String::from("127.0.0.1")),
host_port: None,
}]),
),
(
String::from("443/tcp"),
Some(vec![PortBinding {
host_ip: None,
host_ip: Some(String::from("127.0.0.1")),
host_port: None,
}]),
),
(
String::from("22/tcp"),
Some(vec![PortBinding {
host_ip: None,
host_ip: Some(String::from("127.0.0.1")),
host_port: None,
}]),
)
Expand Down