libcnb-test: Refactor run_pack_command and improve panic messages
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This: - Moves `run_pack_command` to `utils` and makes it generic, so it can be used when calling other external processes (such as Docker CLI, in the upcoming Bollard migration). - Makes `run_command` return a `Result` instead of panicing directly, so that the caller is both in control of the outcome and can add additional context to the panic error message. - Adjusts the formatting of the panic error messages to improve readability (eg adds some additional whitespace, and adjusts the stdout/stderr order). This has been split out of the Bollard migration PR to make it easier to review.
Malax
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
run_pack_commandtoutilsand makes it generic, so it can be used internally when calling other external processes (such as Docker CLI, in the upcoming Bollard migration).run_commandreturn aResultinstead of panicing directly, so that the caller is both in control of the outcome and can add additional context to the panic error message.run_commandand up to the single caller that requires that feature, to avoid adding boilerplate to all of the other call-sites (which will increase in number oncerun_commandis used for Docker CLI after the Bollard migration).This has been split out of the Bollard migration PR to make it easier to review.
GUS-W-13841325.