Refactor libcnb-cargo integration tests #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
force-pushed
the
malax/refactor-libcnb-cargo-tests
branch
from
ff0725e
to
abe0a16
Compare
Malax
commented
Aug 17, 2023
Malax
commented
Aug 17, 2023
Malax
force-pushed
the
malax/refactor-libcnb-cargo-tests
branch
from
abe0a16
to
44c20f2
Compare
Malax
commented
Aug 17, 2023
Malax
force-pushed
the
malax/refactor-libcnb-cargo-tests
branch
from
44c20f2
to
4934fe4
Compare
Malax
force-pushed
the
malax/refactor-libcnb-cargo-tests
branch
from
4934fe4
to
dabd95a
Compare
|
@edmorley, re: #637 (comment) (dunno why I cannot reply inline :() Yeah, the constant will change in the next PR - not the value is temporary. Sorry for the confusion. The new name is I'll skip renaming here. |
colincasey
added a commit
that referenced
this pull request
Aug 18, 2023
* main: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs
colincasey
added a commit
that referenced
this pull request
Aug 18, 2023
…cator * main: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs # libcnb-cargo/src/package/error.rs # libcnb-cargo/tests/test.rs # libcnb-package/src/lib.rs
colincasey
added a commit
that referenced
this pull request
Aug 18, 2023
… libcnb-package/assembling_buildpack_directories * libcnb-package/buildpack_output_directory_locator: Bump buildpacks/github-actions from 5.3.1 to 5.4.0 (#647) Prepare release v0.14.0 (#646) Pin intra-libcnb* crate dependencies to exact versions (#644) Rename libcnb-cargo integration test file (#645) Add version links in the changelog (#643) Update Quick Start Guide (#640) Run `cargo upgrade` as part of preparing libcnb releases (#641) Move packaged buildpack directory out of `target/` (#583) Refactor libcnb-cargo integration tests (#637) libcnb-test: Improve error messages for `address_for_port` (#636) libcnb-test: Implement `fmt::Display` for `LogOutput` (#635) # Conflicts: # CHANGELOG.md # libcnb-cargo/src/package/command.rs # libcnb-package/src/output.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current tests are quite rigid, hard to work with and tricky to extend. I noticed this when the tests became the major blocker to get #583 off the ground. This PR refactors the tests to fix the issues mentioned.
Some extra improvements have landed as well:
fs_extraRef: GUS-W-13966683