Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore file support when finding buildpacks #673

Merged
merged 4 commits into from
Sep 19, 2023

Commits on Sep 13, 2023

  1. Ignore file support when finding buildpacks

    Previously we could rely on knowing that packaged buildpacks would be written to a location within the `target` directory configured in Crate. This was easy to determine through program code and could be supplied to `find_buildpack_dirs` so that packaged buildpacks weren't accidentally included when searching for buildpacks.
    
    With the changes introduced in [#583](#583) it is no longer possible to easily determine the output location for packaged buildpacks. This PR adds the [ignore](https://crates.io/crates/ignore) crate to provide directory iteration that respects standard ignore files. This will give the user the ability to configure where we search within a project for buildpacks.
    colincasey committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d149b15 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. PR feedback

    * updated error message
    * using iterator instead of loop for finding buildpack dirs logic
    * added a quick test to ensure that ignores work
    * updated changelog entry
    colincasey committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    83f8f49 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    * updated error message
    * using iterator instead of loop for finding buildpack dirs logic
    * added a quick test to ensure that ignores work
    * updated changelog entry
    colincasey committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ad247ff View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. PR feedback

    * updated test comments
    * added PR link to changelog entry
    colincasey committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b5770d6 View commit details
    Browse the repository at this point in the history