Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example cargo libcnb package log output in READMEs #675

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Sep 14, 2023

The logs output by cargo libcnb package have changed over recent PRs - this updates the example output to match.

There's still some improvements required to the output (eg #600), however, for now it at least reflects reality.

GUS-W-14121433.

The logs output by `cargo libcnb package` have changed over recent
PRs - this updates the example output to match.

There's still some improvements required to the output (eg #600), however,
for now it at least reflects reality.
@edmorley edmorley added documentation Improvements or additions to documentation skip changelog libcnb-cargo labels Sep 14, 2023
@edmorley edmorley self-assigned this Sep 14, 2023
@edmorley edmorley marked this pull request as ready for review September 14, 2023 08:52
@edmorley edmorley requested a review from a team as a code owner September 14, 2023 08:52
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor Ponda Baba.

@edmorley edmorley merged commit 4ea9d52 into main Sep 14, 2023
7 checks passed
@edmorley edmorley deleted the edmorley/update-cargo-package-example-output branch September 14, 2023 09:22
colincasey added a commit that referenced this pull request Sep 19, 2023
* main:
  Ignore file support when finding buildpacks (#673)
  Apply rustfmt to README example (#676)
  Update example `cargo libcnb package` log output in READMEs (#675)
  Add CLI usage help output to libcnb-cargo README (#674)
  Fix lint errors with Rust 1.73 (#672)
  Include README.md in lib.rs (#667)

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation libcnb-cargo skip changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants