Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Add license to gemspec, License as MIT #11

Merged
merged 2 commits into from
May 25, 2014

Conversation

bf4
Copy link
Contributor

@bf4 bf4 commented Dec 11, 2013

The runtime dependent gems are licensed as New BSD and MIT.

This gem's license omits a line from the New BSD. I'm not an attorney so I'm not sure what to call it, hence 'modified'

Also see https://github.com/pivotal/LicenseFinder/blob/master/lib/data/licenses/NewBSD.txt and bf4/gemproject#1

The dependent gems are licensed as New BSD and MIT.

This gem's license omits a line from the New BSD. I'm not an attorney so I'm not sure what to call it, hence 'modified'
@schneems
Copy link
Contributor

Do we need to include licenses for development dependencies? When installed and running as a gem we're not using rake or minitest. I don't think those dependencies are distributed via rubygems and therefore shouldn't go into the license?

I would prefer to make this gem MIT only if possible, though IANAL

@bf4
Copy link
Contributor Author

bf4 commented Dec 11, 2013

I was actually referring to the runtime dependencies. (updated text above)

I don't think the gemspec should include liceneses from dependent gems.

@schneems
Copy link
Contributor

This gem and the other 2 runtime dependent gems should be MIT unless i screwed something up.

@bf4
Copy link
Contributor Author

bf4 commented Dec 11, 2013

See heroku/rails_serve_static_assets#2 though perhaps this one should also be New BSD. I dunno. https://github.com/heroku/rails_12factor/blob/3420a2/LICENSE

@bf4
Copy link
Contributor Author

bf4 commented Dec 13, 2013

Actually, now I'm thinking that I should repush this as BSD-2 Clause and leave it at that since I think BSD/MIT can be assumed into a project without mention.

I posted a question about this in https://groups.google.com/forum/#!topic/rubygems-developers/9hrhhzILY4c

@bf4
Copy link
Contributor Author

bf4 commented May 20, 2014

I've since learned a bit, and I think that we can specify just MIT for these as it is compatible with BSD.

@schneems
Copy link
Contributor

Seems good. Can you update the PR?

@bf4
Copy link
Contributor Author

bf4 commented May 21, 2014

All MIT all the time, here, heroku/rails_stdout_logging#8 and heroku/rails_serve_static_assets#2

@bf4 bf4 changed the title Add license to gemspec, is modified New BSD, New BSD, and MIT Add license to gemspec, License as MIT May 21, 2014
schneems added a commit that referenced this pull request May 25, 2014
Add license to gemspec, License as MIT
@schneems schneems merged commit e155bd3 into heroku:master May 25, 2014
@schneems
Copy link
Contributor

Triple merge! Thanks ❤️

@bf4
Copy link
Contributor Author

bf4 commented May 26, 2014

Thank you, as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants