Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

https://semver.io/node/resolve/>=6 returns 6.9.1 #62

Closed
apaleslimghost opened this issue Jan 4, 2017 · 4 comments
Closed

https://semver.io/node/resolve/>=6 returns 6.9.1 #62

apaleslimghost opened this issue Jan 4, 2017 · 4 comments

Comments

@apaleslimghost
Copy link

Should currently be 7.4.0. ^6.0.0 is also returning 6.9.1 but it should be 6.9.3.

Similar to #57 but that's apparently fixed.

@JordanBelford
Copy link

If I understand correctly, the stable version is maintained manually, and it also currently resolves to 6.9.1.
Is the latest stable an upper bound on the version that is resolved in an expression like ^6.0.0?

@JordanBelford
Copy link

Resolver.prototype.satisfy in lib/resolver.js has the answer here.

The logic first tries to find a stable version to satisfy the semver expression, which is upper bound by the MAX_STABLE_NODE environment variable. If none is found, it tries to find a match using all available versions, including those greater than MAX_STABLE_NODE. If it still fails it just returns the version in MAX_STABLE_NODE.

Example with MAX_STABLE_NODE = 6.9.1 and actual latest 6.x = 6.9.4
^6.0.0 => 6.9.1
^6.9.2 => 6.9.4
^999.9.9 => 6.9.1

Does it make sense to require manual updating of the stable version? I'm curious about the history there.

@JordanBelford
Copy link

Looks like the update mentioned in #54 is going to take care of this.

@hunterloftis
Copy link
Contributor

resolved by #63

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants