Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

latest node is 6.5.0. ">= 4" resolves to 5.11.1 #57

Closed
tjwebb opened this issue Sep 2, 2016 · 6 comments
Closed

latest node is 6.5.0. ">= 4" resolves to 5.11.1 #57

tjwebb opened this issue Sep 2, 2016 · 6 comments

Comments

@tjwebb
Copy link

tjwebb commented Sep 2, 2016

https://semver.io/node/resolve/%3E=4

engines.node of >= 4 should resolve to the latest version of node, which is 6.5.0, not 5.11. yes? I think 5.x series is nearly EOL already.

If I am wrong, then I'd appreciate any insight on how to write "the largest version number and also greater than 4.0". thanks

@mscdex
Copy link

mscdex commented Sep 2, 2016

It looks like the node module is scraping the https://nodejs.org/dist listing instead of parsing the more appropriate https://nodejs.org/dist/index.json or https://nodejs.org/dist/index.tab

@mgol
Copy link
Contributor

mgol commented Oct 19, 2016

@mscdex That's true (I adapted the existing code when I was adding support for newer Nodes) but it shouldn't affect this issue, all the files are still there.

The stable version is updated manually so one of the maintainers needs to bump it; see #44 (comment).

@mgol
Copy link
Contributor

mgol commented Oct 19, 2016

@hunterloftis could you have a look? Node 5 has been EOL'd for some time so defaulting to it is dangerous.

@Lomand
Copy link

Lomand commented Nov 19, 2016

Is there any news regarding this issue?

@mgol
Copy link
Contributor

mgol commented Nov 30, 2016

This has been fixed. @tjwebb you can close the issue.

@hunterloftis
Copy link
Contributor

resolved by #63

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants