-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default Node.js version to 6.5.0 #67
Conversation
I would wait until v6 enters LTS before bumping up the default. 3 weeks left |
@NiTrOGhost It is currently set to 6.4.0. So... |
That is true, but the node team have 3 weeks to finalise v6 for LTS. Once On 8 Sep 2016 12:27 p.m., "Gocho Mugo" notifications@github.com wrote:
|
@NiTrOGhost That's where the actual default version is defined: https://github.com/icflorescu/openshift-cartridge-nodejs/blob/master/lib/util#L9 (ie. it resolves to 6.5.0 already and PR is just for documentation). The reasoning for "unstable" is here: #48 (comment) (ie. semver.io "stable" is heavily opinionated by Heroku staff, "unstable" is the lastest official release by node.js) |
@apihlaja when v6 lands in LTS, wouldn't the unstable start resolving to v7? still makes sense to wait 3 weeks to change the version because we know for sure that it's all changing on the 1st October |
@NiTrOGhost semver.io resolves node "stable" to 5.11.1 at the moment, which is neither lastest or LTS. For me, it looks pretty random... They have year old issue about updating to new node.js versioning scheme but nothing has happened. I'd call whole site dead at this point.. I'd bet @icflorescu wouldn't mind to see PR removing semver.io ties but obviously, no one wants to spend much time for current gen Openshift when future is unknown. |
Sorry for not pulling this earlier, but I'm currently in a long awaited trekking holiday with sporadic Internet connectivity :-) |
Totally agree about semver's random definition of "stable" vs "unstable". That's why we have the option to force/lock the cartridge to a specific version. |
No description provided.