Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit the process when all components added #119

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix: exit the process when all components added #119

merged 1 commit into from
Dec 7, 2024

Conversation

winchesHe
Copy link
Member

@winchesHe winchesHe commented Dec 7, 2024 •
edited
Loading

📝 Description

Close heroui-inc/heroui#4240

✅ Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Improvement (non-breaking change which improves an existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

@linear Linear
Copy link

linear bot commented Dec 7, 2024

ENG-1655 [BUG] - Next CLI crashes when all components were added

@jrgarciadev jrgarciadev merged commit 0863d3b into main Dec 7, 2024
6 checks passed
@jrgarciadev jrgarciadev deleted the fix/add-no-needed-components-eng-1655 branch December 7, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrgarciadev jrgarciadev jrgarciadev approved these changes

@tianenpang tianenpang Awaiting requested review from tianenpang tianenpang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Next CLI crashes when all components were added
2 participants
@winchesHe @jrgarciadev