Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: init doctor command #7

Merged
merged 16 commits into from
Apr 2, 2024
Merged

feat: init doctor command #7

merged 16 commits into from
Apr 2, 2024

Conversation

winchesHe
Copy link
Member

@winchesHe winchesHe commented Mar 30, 2024

Doctor command finish

Dependencies Show

1、Check whether redundant denpendencies

2、Check allComponents required dependencies has installed correctly

CleanShot 2024-03-31 at 00 08 19

3、Check Individual Components required dependencies has installed correctly

image

Tailwind Show

4、Check Individual Components missing tailwindcss.config.js required content

image image
  • When just a Component installed the log will auto change
image
  • When the installed is @nextui-org/react the log will auto change
image

App Show

  • Missing App file
image
  • Missing NextUIProvider
image

Pnpm Show

If the package manager is Pnpm, and then it will check the .npmrc file is correct

image

Optimize Tailwind Output

1、Missing `tailwind.config.(j|t)s
image

2、Add detect tailwind.config.ts

image

@jrgarciadev
Copy link
Member

@winchesHe I think that we could also check these scenarios

@winchesHe
Copy link
Member Author

@winchesHe I think that we could also check these scenarios

Got, the doctor PR is still draft WIP I will draft it untill finished full funtionality

@winchesHe winchesHe marked this pull request as draft March 31, 2024 02:22
README.md Outdated Show resolved Hide resolved
src/actions/doctor-action.ts Outdated Show resolved Hide resolved
src/actions/doctor-action.ts Outdated Show resolved Hide resolved
src/helpers/check.ts Outdated Show resolved Hide resolved
src/helpers/check.ts Outdated Show resolved Hide resolved
src/helpers/check.ts Outdated Show resolved Hide resolved
src/helpers/check.ts Outdated Show resolved Hide resolved
src/helpers/check.ts Outdated Show resolved Hide resolved
@jrgarciadev
Copy link
Member

@winchesHe we also need to consider TailwindCSS TS/ESM config file https://tailwindcss.com/docs/configuration#using-esm-or-type-script

So we need to identify whether the user is using tailwind.config.js or tailwind.config.ts and adapt the doctor's suggestions/comments on top of that file

@winchesHe
Copy link
Member Author

@winchesHe we also need to consider TailwindCSS TS/ESM config file https://tailwindcss.com/docs/configuration#using-esm-or-type-script

So we need to identify whether the user is using tailwind.config.js or tailwind.config.ts and adapt the doctor's suggestions/comments on top of that file

Yes, I will fix all the issues above🙌

@winchesHe winchesHe marked this pull request as ready for review April 1, 2024 13:27
Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🔥 @winchesHe just a small comment, feel free to merge this once fixed

@winchesHe winchesHe merged commit 9e04fd4 into main Apr 2, 2024
3 checks passed
@winchesHe winchesHe deleted the feature-doctor branch April 2, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants