fix(navbar): applying suggested changes

heroui-inc · Jun 25, 2024 · aa72c23 · aa72c23
1 parent ba3dfbf
commit aa72c23
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.changeset/happy-cameras-whisper.md b/.changeset/happy-cameras-whisper.md
@@ -1,5 +1,5 @@
 ---
-"@nextui-org/use-scroll-position": minor
+"@nextui-org/use-scroll-position": patch
 ---
 
-clearing throttleTimeout when it is supposed to be null in useScrollPosition
+clearing throttleTimeout when it is supposed to be null in useScrollPosition (#3139)
diff --git a/packages/hooks/use-scroll-position/src/index.ts b/packages/hooks/use-scroll-position/src/index.ts
@@ -59,12 +59,11 @@ export const useScrollPosition = (props: UseScrollPositionOptions): ScrollValue
 
     const handleScroll = () => {
       if (delay) {
-        if (throttleTimeout.current === null) {
-          throttleTimeout.current = setTimeout(handler, delay);
-        } else {
+        if (throttleTimeout.current) {
           clearTimeout(throttleTimeout.current);
-          throttleTimeout.current = setTimeout(handler, delay);
         }
+
+        throttleTimeout.current = setTimeout(handler, delay);
       } else {
         handler();
       }