Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make VisuallyHidden's element type as span when it's inside phrasing element #3013

Merged
merged 8 commits into from
May 20, 2024
Merged

fix: make VisuallyHidden's element type as span when it's inside phrasing element #3013

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8bfaa9f
fix(checkbox): make VisuallyHidden's element type as span
kosmotema May 16, 2024
6ea4a61
feat(changeset): add changeset
kosmotema May 16, 2024
d047e86
fix(radio): make the VisuallyHidden element type as span
kosmotema May 16, 2024
d25e5ab
fix(switch): make the VisuallyHidden element type as span
kosmotema May 16, 2024
25fef8b
fix(select): make the VisuallyHidden element type as span
kosmotema May 16, 2024
7b3b5d1
feat(changeset): replace changeset
kosmotema May 16, 2024
e5c63b6
Merge branch 'canary' into fix/checkbox
kosmotema May 20, 2024
0cfd6e1
chore: fix formatting
kosmotema May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/thick-frogs-jog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@nextui-org/checkbox": patch
"@nextui-org/radio": patch
"@nextui-org/select": patch
"@nextui-org/switch": patch
---

make the VisuallyHidden `elementType` as span when the default parent element accepts only phrasing elements
2 changes: 1 addition & 1 deletion packages/components/checkbox/src/checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const Checkbox = forwardRef<"input", CheckboxProps>((props, ref) => {

return (
<Component {...getBaseProps()}>
<VisuallyHidden>
<VisuallyHidden elementType="span">
wingkwong marked this conversation as resolved.
Show resolved Hide resolved
<input {...getInputProps()} />
</VisuallyHidden>
<span {...getWrapperProps()}>{clonedIcon}</span>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/radio/src/radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const Radio = forwardRef<"input", RadioProps>((props, ref) => {

return (
<Component {...getBaseProps()}>
<VisuallyHidden>
<VisuallyHidden elementType="span">
<input {...getInputProps()} />
</VisuallyHidden>
<span {...getWrapperProps()}>
Expand Down
2 changes: 1 addition & 1 deletion packages/components/select/src/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
<div {...getInnerWrapperProps()}>
{startContent}
<span {...getValueProps()}>{renderSelectedItem}</span>
{endContent && state.selectedItems && <VisuallyHidden>,</VisuallyHidden>}
{endContent && state.selectedItems && <VisuallyHidden elementType="span">,</VisuallyHidden>}

Check warning on line 133 in packages/components/select/src/select.tsx

View workflow job for this annotation

GitHub Actions / ESLint 

Replace `<VisuallyHidden·elementType="span">,</VisuallyHidden>` with `(⏎··············<VisuallyHidden·elementType="span">,</VisuallyHidden>⏎············)`
wingkwong marked this conversation as resolved.
Show resolved Hide resolved
{endContent}
</div>
{renderIndicator}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/switch/src/switch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const Switch = forwardRef<"input", SwitchProps>((props, ref) => {

return (
<Component {...getBaseProps()}>
<VisuallyHidden>
<VisuallyHidden elementType="span">
<input {...getInputProps()} />
</VisuallyHidden>
<span {...getWrapperProps()}>
Expand Down
Loading