chore: fixing the url in heroui pro section #4620
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request involves updating image source paths in the Changes
The specific path changes include:
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
macci001
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/docs/components/marketing/heroui-pro-section.tsx (2)
Line range hint
132-143: Add alt text that better describes the background image content.The current alt text "Hero Background" is too generic. Consider providing a more descriptive alt text that explains what the image contains, improving accessibility for screen reader users.
<img - alt="Hero Background" + alt="HeroUI Pro component showcase featuring a collection of UI elements and templates" className="w-full" height={3255} loading="lazy" src={imgSrc} width={1920} />
Line range hint
115-126: Consider adding aria-label to the CTA button for better accessibility.The button includes an icon but no descriptive text for screen readers about opening in a new tab.
<Button as={"a"} className="px-6 flex items-center" color="primary" href="https://heroui.pro?utm_source=heroui.com&utm_medium=heroui-homepage-section" rel="noopener noreferrer" target="_blank" + aria-label="Explore HeroUI Pro (opens in new tab)" > Explore HeroUI Pro
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/docs/components/marketing/heroui-pro-section.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: TypeScript
- GitHub Check: Build
🔇 Additional comments (1)
apps/docs/components/marketing/heroui-pro-section.tsx (1)
28-29: Verify that the new image assets exist in the repository.The image paths have been updated from "nextuipro" to "herouipro". Let's ensure these assets are present.
Also applies to: 32-33
✅ Verification successful
✓ Image assets verification successful
All referenced image assets exist in the correct location (
apps/docs/public/images/), including both mobile and desktop versions for light and dark modes.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the new image assets exist fd -e webp 'herouipro-section-background' public/images/Length of output: 158
Script:
#!/bin/bash # Find all webp files in the repository echo "=== Finding all .webp files ===" fd -e webp # Search for references to the image paths in code echo -e "\n=== Searching for image references ===" rg -i "herouipro-section-background.*\.webp"Length of output: 1057
macci001
force-pushed
the
macci001/fix-heroui-pro-section-url
branch
from
007d1b9 to
51f52b8
Compare
Closes #
📝 Description
FIxing the url for the herouipro section in the home page
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit