add a test #20
Merged
add a test #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumieval
commented
Aug 8, 2022
tests/stdout.hs
Outdated
| logM [ #emerg, "lorem ipsum" ] | ||
|
|
||
|
|
||
| threadDelay $ 1000 * 10 |
|
テストケースを足してみました。 |
|
お、ありがとうございます。せっかく増やしてもらったところ恐縮ですが、一連の処理は同じ関数として定義して、ロガーのレベルを引数として渡すようにしてもらえるとコードの重複が減り、テストも一つにまとめられるので、そうしてもらえるとありがたいです |
|
コメントありがとうございます。修正してひとつにまとめてみましたが、どうでしょうか？ |
|
ありがとうございます。「ロガーのレベルを引数として渡す」ところはまだできていないようですね |
|
すみません、「ロガーのレベルを引数として渡す」の部分を反映していませんでした。一応やってみたんですがこんな感じでしょうか？ |
|
まさにそういうことです！ |
ccycle
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdoutTransportのテストを作った