new takes a Config record (fixes #12)
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumieval
changed the title
new takes a Config recordnew takes a Config record (fixes #12)
ccycle
reviewed
Sep 7, 2022
| { createTransports :: IO [Transport] | ||
| , concurrencyLevel :: ConcurrencyLevel | ||
| , logLevel :: LogLevel | ||
| } |
There was a problem hiding this comment.
Config という名前を使うと他のモジュールと衝突が起きる可能性が大きくなるので、ここの名前を LoggerConfig みたいにLoggerにちなんだものにするといいんじゃないかと思ったのですがどうでしょうか？
There was a problem hiding this comment.
newの時点でけっこう被りやすいので微妙なところですが、確かにLoggerConfigにするデメリットもないのでそうします
src/Herp/Logger.hs
Outdated
| , new | ||
| , def |
There was a problem hiding this comment.
def を再exportするよりは defaultLoggerConfig として新しく関数を定義したほうが(defの用途をLogger用に制限するという意味で)いいんじゃないかと思いました、ただ自分がDefaultインスタンスを作るメリットをよく分かってないだけな気もします
defaultLoggerConfig :: Config
defaultLoggerConfig = Config
{ createTransports = do
ls <- newStdoutLoggerSet 4096
pure [stdoutTransport ls Debug]
, concurrencyLevel = 1
, logLevel = Debug
}There was a problem hiding this comment.
Herp.Loggerをunqualifiedでインポートする前提で名前を変更しました
fumieval
force-pushed
the
logger-config
branch
from
60443df to
2dec6a2
Compare
ccycle
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newの引数としてレコードを取ることにより、APIの拡張性、安定性、わかりやすさを高めた。さらにデフォルト値として stdoutTransportを作成することにより、fast-loggerをインポートすることなく簡単にロガーを作成できるようにした。