Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve runLoggingT #24

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Improve runLoggingT #24

merged 1 commit into from
Oct 5, 2022

Conversation

ccycle
Copy link
Contributor

@ccycle ccycle commented Oct 5, 2022

runLoggingT の型制約を緩め、IO () 以外にも使えるよう修正してみました。

@ccycle ccycle requested a review from fumieval October 5, 2022 01:17
fumieval
fumieval approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@fumieval fumieval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccycle ccycle merged commit e5ed098 into master Oct 5, 2022
@ccycle ccycle deleted the improve-runLoggingT branch October 5, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumieval fumieval fumieval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccycle @fumieval