Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordLogを削除 etc #25

Merged
merged 3 commits into from
Oct 5, 2022
Merged

recordLogを削除 etc #25

merged 3 commits into from
Oct 5, 2022

Conversation

fumieval
Copy link
Contributor

@fumieval fumieval commented Oct 5, 2022

ロガーのインターフェイスは統一したい・依存を減らしたいので、現状かなり浮いている recordLog 関数は削除した。代わりにアプリケーション側でToJSONPBを呼ぶようにしたい

@fumieval fumieval requested a review from ruicc October 5, 2022 08:27
Copy link
Contributor

@ruicc ruicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fumieval fumieval merged commit 3a665be into master Oct 5, 2022
@ccycle ccycle deleted the tidyup branch October 6, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants