Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of the sentry backend #33

Merged
merged 1 commit into from
Dec 27, 2022
Merged

get rid of the sentry backend #33

merged 1 commit into from
Dec 27, 2022

Conversation

fumieval
Copy link
Contributor

HERPとしてSentryは使わない方向にシフトしているので、潔く実装を消した。本当に必要になったら別パッケージとして復活させる。

@fumieval fumieval requested a review from ruicc December 26, 2022 11:28
ruicc
ruicc approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@ruicc ruicc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います。datadogのlog patternが便利なことも分かったので。

@fumieval fumieval merged commit 9129a7d into master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruicc ruicc ruicc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fumieval @ruicc