TransportをVectorで持つようにする #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ynishinaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
taglake (release-20230306-0)でプロファイルを取ったところ、logger周りのメモリ使用量が増加しがちだった(ちなみにこれはherp-loggerがresource-pool 0.4対応する前の結果ですが、resource-pool 0.4を使うようにしても同じような結果になります):
そこで、
createTransportsとtransportsをリストからVectorにしたところ、logger周りのメモリ使用量が改善された雰囲気が出てきた:taglake release-20230306-0は
createTransportsの要素数が１なので、なぜこれで改善されるのかはよく分かっていません