Merge pull request #6 from bodhisatan/fix_set_cookie

Fix set cookie
hertz-contrib · Jul 27, 2022 · d3ddd58 · d3ddd58
2 parents 00768db + d3453c1
commit d3ddd58
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml
@@ -26,13 +26,6 @@ jobs:
         with:
           go-version: 1.18
 
-      - uses: actions/cache@v3
-        with:
-          path: ~/go/pkg/mod
-          key: reviewdog-${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            reviewdog-${{ runner.os }}-go-
-
       - uses: reviewdog/action-staticcheck@v1
         with:
           github_token: ${{ secrets.github_token }}

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -13,13 +13,6 @@ jobs:
         with:
           go-version: 1.18
 
-      - uses: actions/cache@v3
-        with:
-          path: ~/go/pkg/mod
-          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-go-
-
       - name: Lint
         run: |
           go vet -stdmethods=false $(go list ./...)

diff --git a/auth_jwt.go b/auth_jwt.go
@@ -537,7 +537,6 @@ func (mw *HertzJWTMiddleware) LoginHandler(ctx context.Context, c *app.RequestCo
 
 		if mw.CookieSameSite != 0 {
 			cookie.SetSameSite(protocol.CookieSameSite(mw.CookieSameSite))
-			c.Response.Header.SetCookie(cookie)
 		}
 		cookie.SetKey(mw.CookieName)
 		cookie.SetValue(tokenString)
@@ -559,7 +558,6 @@ func (mw *HertzJWTMiddleware) LogoutHandler(ctx context.Context, c *app.RequestC
 		cookie := &protocol.Cookie{}
 		if mw.CookieSameSite != 0 {
 			cookie.SetSameSite(protocol.CookieSameSite(mw.CookieSameSite))
-			c.Response.Header.SetCookie(cookie)
 		}
 		cookie.SetKey(mw.CookieName)
 		cookie.SetValue("")
@@ -629,7 +627,6 @@ func (mw *HertzJWTMiddleware) RefreshToken(ctx context.Context, c *app.RequestCo
 
 		if mw.CookieSameSite != 0 {
 			cookie.SetSameSite(protocol.CookieSameSite(mw.CookieSameSite))
-			c.Response.Header.SetCookie(cookie)
 		}
 		cookie.SetKey(mw.CookieName)
 		cookie.SetValue(tokenString)