Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging/zap): fix span status error #22

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

rogerogers
Copy link
Collaborator

What type of PR is this?

fix(logging/zap): fix span status error

What this PR does / why we need it (English/Chinese):

en: fix span status error in zap logger
zh: 修正了zap日志包中设置span状态错误

Which issue(s) this PR fixes:

Signed-off-by: rogerogers <rogers@rogerogers.com>
Copy link
Collaborator

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@GuangmingLuo GuangmingLuo merged commit 6a9c6ca into hertz-contrib:main Aug 21, 2023
9 checks passed
@rogerogers rogerogers deleted the fix/zap-status branch August 21, 2023 02:54
li-jin-gou pushed a commit to li-jin-gou/obs-opentelemetry that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants