Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): not report status code 200 when http client returns error #50

Merged

Conversation

2011aad
Copy link
Contributor

@2011aad 2011aad commented Mar 14, 2024

What type of PR is this?

fix(metrics): do not report status code 200 when http client returns error

What this PR does / why we need it (English/Chinese):

en: Currently, http client report metrics status code as 200 when client returns an error.
zh: 当前在http客户端返回错误时,metrics上报的status code是200。

Which issue(s) this PR fixes:

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

tracing/middleware.go Outdated Show resolved Hide resolved
@CoderPoet
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jianzhang.kk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@2011aad CLA 需要处理下哈

@2011aad 2011aad force-pushed the feature/fix-report-status-code-on-error branch from fb5258a to 06d4920 Compare March 14, 2024 12:34
@rogerogers
Copy link
Collaborator

ci 的 lint 需要修下

Copy link
Collaborator

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@rogerogers rogerogers merged commit 34c24d2 into hertz-contrib:main Mar 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants