Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support service registeration and discovery with Netflix Eureka #16

Merged
merged 47 commits into from
Aug 28, 2022
Merged

feat: support service registeration and discovery with Netflix Eureka #16

merged 47 commits into from
Aug 28, 2022

Conversation

Haswf
Copy link
Collaborator

@Haswf Haswf commented Aug 28, 2022

What type of PR is this?

feat: support service registeration and discovery with Netflix Eureka. This is part of the community's onging effort to integrate hertz with mainstream service discovery solutions. cloudwego/hertz#197

What this PR does / why we need it (English/Chinese):

support service registeration and discovery with Netflix Eureka

Which issue(s) this PR fixes:

None

Haswf and others added 30 commits August 21, 2022 03:28
@Haswf
feat: add eureka registry
e666fb6
@Haswf
feat: add eureka resolver
85c821e
@Haswf
style: run gofumpt
7e71623
@Haswf
test: add test cases
f43e5a1
@zstone12 @Haswf
feat: zookeeper init code
c5677a9
@zstone12 @Haswf
chore: simplify dupliate code && no eps return nil
2374cb2
@zstone12 @Haswf
style: import style
d8e6f9e
@zstone12 @Haswf
chore: remove utils/entity folder && use Localp
c658aad
@zstone12 @Haswf
fix: typo
203dbdf
@zstone12 @Haswf
chore: change basic -> standard
00d541c
@zstone12 @Haswf
refactor: use local utils to get ipv4Address
2c2a192
@zstone12 @Haswf
fix: add cacheKey
e820c96
@zstone12 @Haswf
test: unit test assert nil
ae552af
@zstone12 @Haswf
style: add license header
708ea72
@zstone12 @Haswf
fix: handle host :: case
0932c52
@zstone12 @Haswf
doc: add compatibility part
b1c5d38
@zstone12 @Haswf
refactor: use Localp instead of local utils
94034ff
@zstone12 @Haswf
test: add assert for reslove
13c03ed
@zstone12 @Haswf
test: add test with hertz
ee143ff
@zstone12 @Haswf
style: add license header && gofumpt
0b88fdc
@zstone12 @Haswf
style: add newline to end of file
cd9ca96
@zstone12 @Haswf
doc: optimize README.md format
8fff6d9
@zstone12 @Haswf
fix: handle host :: case && optimize getInstances code
14d6524
@zstone12 @Haswf
fix: resolver & licences typo
30303b3
@zstone12 @Haswf
test: merge test file && remove judge len(ep)
5d19ee0
@zstone12 @Haswf
doc: first letter upper
483630e
@zstone12 @Haswf
fix: lint error
03819c8
@zstone12 @Haswf
feat: optimize buildPath code
94c1525
@zstone12 @Haswf
style: add comment for test func
90e9154
@zstone12 @Haswf
style: license folders name typo (hertz-contrib#11)
d0a4e8e
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/Makefile Outdated Show resolved Hide resolved
eureka/entity.go Outdated Show resolved Hide resolved
eureka/error.go Outdated Show resolved Hide resolved
eureka/eureka_test.go Show resolved Hide resolved
eureka/eureka_test.go Show resolved Hide resolved
@li-jin-gou li-jin-gou requested a review from Skyenought August 28, 2022 14:41
Skyenought
Skyenought reviewed Aug 28, 2022
View reviewed changes
eureka/registry.go Outdated Show resolved Hide resolved
Skyenought
Skyenought reviewed Aug 28, 2022
View reviewed changes
eureka/registry.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/eureka_test.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/README.md Outdated Show resolved Hide resolved
Skyenought
Skyenought reviewed Aug 28, 2022
View reviewed changes
eureka/README.md Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/README.md Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/eureka_test.go Outdated Show resolved Hide resolved
Haswf
Haswf commented Aug 28, 2022
View reviewed changes
eureka/registry.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/registry.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/go.mod Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 28, 2022
View reviewed changes
eureka/registry.go Outdated Show resolved Hide resolved
@li-jin-gou li-jin-gou requested a review from zstone12 August 28, 2022 16:23
Skyenought
Skyenought approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@li-jin-gou
Copy link
Collaborator

LGTM

@li-jin-gou li-jin-gou merged commit 07aa61b into hertz-contrib:main Aug 28, 2022
@Haswf Haswf deleted the feat_eureka branch August 29, 2022 11:38
@Skyenought Skyenought mentioned this pull request Aug 29, 2022
Closed
3 tasks
@Haswf Haswf mentioned this pull request Jan 13, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou left review comments

@Skyenought Skyenought Skyenought approved these changes

@zstone12 zstone12 zstone12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Haswf @li-jin-gou @zstone12 @Skyenought @rogerogers @qiuyuyin