Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zookeeper register #6

Merged
merged 25 commits into from
Aug 24, 2022
Merged

feat: add zookeeper register #6

merged 25 commits into from
Aug 24, 2022

Conversation

zstone12
Copy link
Collaborator

@zstone12 zstone12 commented Aug 14, 2022 •
edited by li-jin-gou
Loading

What type of PR is this?

add register zookeeper

What this PR does / why we need it (English/Chinese):

Which issue(s) this PR fixes:

part of cloudwego/hertz#197

Todo:

  • add example with auth zookeeper.
  • makefile change to docker.
  • add licenses.
  • optimize README.
  • add unit test with hertz.
  • update hertz dependency.

@zstone12 zstone12 changed the title feat: register-zookeeper(WIP) feat: add zookeeper register(WIP) Aug 19, 2022
@zstone12 zstone12 changed the title feat: add zookeeper register(WIP) feat: add zookeeper register Aug 21, 2022
li-jin-gou
li-jin-gou reviewed Aug 23, 2022
View reviewed changes
zookeeper/README.md Outdated Show resolved Hide resolved
zookeeper/utils/net.go Outdated Show resolved Hide resolved
zookeeper/entity/entity.go Outdated Show resolved Hide resolved
zookeeper/utils/const.go Outdated Show resolved Hide resolved
zookeeper/example/basic/client/main.go Outdated Show resolved Hide resolved
zookeeper/registry.go Outdated Show resolved Hide resolved
zookeeper/registry.go Show resolved Hide resolved
zookeeper/reslover.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 23, 2022
View reviewed changes
zookeeper/example/basic/client/main.go Outdated Show resolved Hide resolved
zookeeper/README.md Show resolved Hide resolved
zookeeper/reslover.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 24, 2022
View reviewed changes
zookeeper/zookeeper_test.go Outdated Show resolved Hide resolved
zookeeper/zookeeper_test.go Outdated Show resolved Hide resolved
zookeeper/registry.go Outdated Show resolved Hide resolved
zookeeper/reslover.go Outdated Show resolved Hide resolved
zookeeper/zookeeper_test.go Outdated Show resolved Hide resolved
zookeeper/discovery_test.go Outdated Show resolved Hide resolved
GuangmingLuo
GuangmingLuo reviewed Aug 24, 2022
View reviewed changes
zookeeper/README.md Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Aug 24, 2022
View reviewed changes
zookeeper/registry.go Outdated Show resolved Hide resolved
Skyenought
Skyenought reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reslover.go -> resolver.go

@zstone12 zstone12 merged commit 9dab6bb into hertz-contrib:main Aug 24, 2022
@Skyenought Skyenought mentioned this pull request Aug 29, 2022
Closed
3 tasks
@zstone12 zstone12 mentioned this pull request Nov 23, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skyenought Skyenought Skyenought left review comments

@li-jin-gou li-jin-gou li-jin-gou approved these changes

@GuangmingLuo GuangmingLuo GuangmingLuo approved these changes

@baiyutang baiyutang Awaiting requested review from baiyutang

@bodhisatan bodhisatan Awaiting requested review from bodhisatan

@FGYFFFF FGYFFFF Awaiting requested review from FGYFFFF

@welkeyever welkeyever Awaiting requested review from welkeyever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zstone12 @GuangmingLuo @Skyenought @li-jin-gou