-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add addition info for consul #86
feat: add addition info for consul #86
Conversation
Please check the Tests / ut - there are issues in it. |
It seems to be a Nacos problem, not caused by this PR. Can you rerun it for me, and I will check if there is still a problem. |
@L2ncE please check the test result. |
Got it, I'll fix it in my spare time. |
@welkeyever @GuangmingLuo PTAL❤️ |
@li-jin-gou please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx~
齐哥在跟进修复了
…---Original---
From: "Xinhao ***@***.***>
Date: Thu, Dec 28, 2023 11:48 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [hertz-contrib/registry] feat: add addition info for consul (PR#86)
@L2ncE commented on this pull request.
In consul/registry.go:
> @@ -88,7 +99,8 @@ func (c *consulRegistry) Register(info *registry.Info) error { Name: info.ServiceName, Address: host, Port: port, - Meta: info.Tags,
这个地方有问题
什么问题
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
What type of PR is this?
feat
What this PR does / why we need it (English/Chinese):
在之前的 Consul 拓展实现中,直接使用 Hertz 提供的 Info 结构体中的 Tags 作为 Consul 的 Meta,并且 Consul 非常重要的 Tags 也没有进行配置的入口。因此在这里提供了一个新的结构体来为用户方便配置 Tags 与 Meta。
In the previous Consul extension implementation, the Tags field in the Info structure provided by Hertz was directly used as the Meta value of Consul, and the very important Tags field of Consul did not have an entry for configuration.
Therefore, a new structure is provided here to facilitate the configuration of Tags and Meta for users.
Which issue(s) this PR fixes:
cloudwego/hertz#596