Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build with Go 1.23 #863

Closed
wants to merge 1 commit into from
Closed

feat: build with Go 1.23 #863

wants to merge 1 commit into from

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 6, 2024

Since Go 1.21 is not supported anymore, we should upgrade our Go version. The CLI is a standalone application, so we can skip Go 1.22 and use 1.23.

@phm07 phm07 self-assigned this Sep 6, 2024
@phm07 phm07 requested a review from a team as a code owner September 6, 2024 11:07
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.33%. Comparing base (311642e) to head (38cdc6a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #863      +/-   ##
==========================================
- Coverage   61.49%   60.33%   -1.17%     
==========================================
  Files         238      242       +4     
  Lines        8522     8686     +164     
==========================================
  Hits         5241     5241              
- Misses       2572     2736     +164     
  Partials      709      709              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 closed this Sep 6, 2024
@phm07 phm07 deleted the go-1.23 branch September 16, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant