Use SDK communicator to generate SSH key pair #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* support ecdsa, ed25519 temporary key algos via `temporary_key_pair_type` config * clean up unused properties
(OpenSSH>=8.2 deprecates `ssh-rsa` pub key algorithm, see hashicorp/packer#10074 hashicorp/packer#8609), change docs accordingly
|
|
|
I signed the CLA and am awaiting feedback on this PR |
nywilken
approved these changes
Aug 3, 2022
|
The missing documentation partial was added a follow to this change. Thanks for the contribution. |
|
Cheers! I think this fixes #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a
communicator.StepSSHKeyGento let the communicator pre-generate the SSH key pair, used that key and removed the code that creates a new RSA SSH key pair instepCreateSSHKey.This means the plugin now supports
temporary_key_pair_typeandtemporary_key_pair_bits.I used digitalocean/packer-plugin-digitalocean@e88d4df as a baseline.
I've run the acceptance test and it completes successfully, after adding the required
ssh_username.I don't think this needs any change to the docs.