Fixed select-search-field #19
Conversation
EVCareeria
commented
Dec 5, 2022
EVCareeria
commented
- Some state flow changes
- Allows searching of users
- Allows picking of the current user through search
- Some state flow changes - Allows searching of users - Allows picking of the current user through search
| if( searchField ) setSearchField('') | ||
| }, | ||
| [ | ||
| updateCurrentItemIndexCallback, |
There was a problem hiding this comment.
Why do you set these as the dependency when they aren't used inside the callback?
Also why is there no dependency for searchField and setSearchField...
Also probably better would be to use setSearchField((value) => value ? value : '') -- that way you don't need the if clause or dependency for the current value, and it works asynchronously correctly (maybe).
There was a problem hiding this comment.
This callback is only used to nullify the SearchField after user selects an item, so that full list of items can be seen afterwards.
Currently this is the only place where SearchField is emptied, if I set SearchField as dependency then the field nullifies itself everytime when someone starts typing, thus filtering doesn't work.
Ofcourse the Callback function itself is quite pointless in this case, the setSearchField could be called from functions that I use as dependency, but in that case the logic is spread around instead of getting called from one specific place.
